Update prettier to latest version #10838
Conversation
| singleQuote: true, | ||
| printWidth: 120, | ||
| tabWidth: 4, | ||
| trailingComma: 'none', |
There was a problem hiding this comment.
Retaining backwards compatibility (inline with our tslint config as well).
There was a problem hiding this comment.
Per the docs, the default is "es5" - Trailing commas where valid in ES5 (objects, arrays, etc.). The third option is 'all', which sounds like it requires extra effort (not worth it).
So why not use the default ("es5") here? FWIW, I've found trailing commas to be convenient and that having them causes less churn when adding or removing entries.
There was a problem hiding this comment.
Sorry, @ericsnowcurrently Will do that separately, I didn't want to change the existing style from no trailing comma to trailing comma.
Will do that, had to merge
| | ||
| performanceJson.forEach(result => { | ||
| const cleanTimes = result.times.filter(x => x !== -1); | ||
| performanceJson.forEach((result) => { |
There was a problem hiding this comment.
Default setting in prettier is to add (), i've left that as is.
| Kudos, SonarCloud Quality Gate passed!
|
4 participants
For #10837