static_assert ignored in SFINAE and operator ==, != issues #5163
Description
Type: LanguageService
Describe the bug
- OS and Version: Archlinux, bleeding edge
- VS Code Version: 1.43.0 (oss build vscodium)
- C/C++ Extension Version: 0.27.0-insiders3
- Other extensions you installed (and if the issue persists after disabling them): Ton of other extension but nothing C/C++ related, should I disable them all? I there easy way?
- Tested only locally
Steps to reproduce
c_cpp_propertis.json
{ "configurations": [ { "name": "Linux", "includePath": [ "${workspaceFolder}/**" ], "defines": [], "compilerPath": "/usr/bin/clang", "intelliSenseMode": "clang-x64", "configurationProvider": "vector-of-bool.cmake-tools" } ], "version": 4 }for quick access cpp file in gist also attached in zip
Verify, that template works as expected
static_list flags in Derived class tells Base class which asserts deactivate and thus enable some operators
- try to compile flagtest with gcc (tested 9.2.1)/clang (tested 9.0) with --std=c++2a everything works as expected
- uncomment line 78
a <= b; - compile, compilation fails on
static_assertas expected - add
OperatorRequirements::LEQto list in line 65, this enables operator<=by deactivating static_assert - compile, compilation succeeeds, as expected -> templates works as intended
vscode behavior
- get
flags.cppinto original state - uncomment lines 77~80
- observe vscode info about operators:
a)a < b;vscode does no complain (OK), compiles (OK)
b)a <= b;vscode does no complain (wrong, operator does not exist due to static_assert), compilation fails due to static_assert on line 52 (OK)
c)a == bvscode complains:
more than one operator "==" matches these operands: -- function "Base<Derived>::operator==(const Derived &rhs) const [with Derived=Child]" (with reversed arguments) -- function "Base<Derived>::operator==(const Derived &rhs) const [with Derived=Child]" -- operand types are: Child == Child Compiles fine
d) a!=b vscode complains:
more than one operator "!=" matches these operands: -- function "Base<Derived>::operator==(const Derived &rhs) const [with Derived=Child]" (with reversed arguments) -- function "Base<Derived>::operator==(const Derived &rhs) const [with Derived=Child]" -- operand types are: Child != Child Compilation fails (g++ error):
../src/flagtest.cpp: In function ‘int main()’: ../src/flagtest.cpp:80:4: error: no match for ‘operator!=’ (operand types are ‘Child’ and ‘Child’) 80 | a != b; //vscode complains about multiple != operators (wrong), non of them exist and compilations fails (OK) | ~ ^~ ~ | | | | | Child | Child Expected behavior
- complain about not existing implementation of
<=operator when disabled by static assert - do not complain about
==operator when there is only one implementation - complain correclty about
!=operator missing
Logs
c_cpp_server_log
just commented lines to state when source compiles, nothing interesting there
cpptools/getCodeActions: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 451) cpptools/activeDocumentChange: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp cpptools/textEditorSelectionChange cpptools/textEditorSelectionChange idle loop: reparsing the active document Checking for syntax errors: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp Queueing IntelliSense update for files in translation unit of: /home/diggit/dev/flagtest/soclim/src/flagtest.cpp cpptools/cpptools_finishUpdateSquiggles Error squiggle count: 1 Update IntelliSense time (sec): 0.259 Database safe to open tag parsing file: /home/diggit/dev/flagtest/soclim/src/flagtest.cpp cpptools/getDocumentSymbols: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 452) cpptools/getDocumentSymbols Database safe to open cpptools/activeDocumentChange: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp cpptools/textEditorSelectionChange cpptools/textEditorSelectionChange cpptools/getCodeActions: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 453) idle loop: reparsing the active document Checking for syntax errors: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp Queueing IntelliSense update for files in translation unit of: /home/diggit/dev/flagtest/soclim/src/flagtest.cpp textDocument/hover: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 454) cpptools/cpptools_finishUpdateSquiggles Error squiggle count: 1 Update IntelliSense time (sec): 0.264 cpptools/getCodeActions: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 455) textDocument/hover: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 456) textDocument/hover: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 457) cpptools/getCodeActions: file:///home/diggit/dev/flagtest/soclim/src/flagtest.cpp (id: 458) Screenshots
