Integrate 0.82.0-nightly-20250806-5936f29d6 #15261
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added to avoid conflicts in integration
This was referenced Oct 17, 2025
vineethkuttan force-pushed the integrate3.0 branch 2 times, most recently from c6cd45a to ba72f25 Compare vineethkuttan force-pushed the integrate3.0 branch from fe9124e to b4eabb5 Compare vineethkuttan force-pushed the integrate3.0 branch from 5867212 to dc01d2e Compare vineethkuttan force-pushed the integrate3.0 branch from b3471d0 to 7d606cc Compare 
tido64 reviewed Oct 28, 2025
Comment on lines 34 to 36
| new RegExp(`${rnwPath}/build/[/\\]`), | ||
| new RegExp(`${rnwPath}/target/[/\\]`), | ||
| /[/\\]\.ProjectImports\.zip/, |
There was a problem hiding this comment.
.* is not the same as [/\\]. The first greedy matches any character, the latter only matches a single instance / or \. We already have a trailing / here so we shouldn't add another:
Suggested change
| new RegExp(`${rnwPath}/build/[/\\]`), | |
| new RegExp(`${rnwPath}/target/[/\\]`), | |
| /[/\\]\.ProjectImports\.zip/, | |
| new RegExp(`${rnwPath}/build/`), | |
| new RegExp(`${rnwPath}/target/`), | |
| /\.ProjectImports\.zip$/, |
I see you've done the same mistake in the other config files as well. I suggest you revert to what you had previously as what I did in microsoft/rnx-kit#3783 was merely performance optimizations. We can go over these in a separate PR.
vineethkuttan force-pushed the integrate3.0 branch from b6e8e20 to 967d159 Compare vineethkuttan force-pushed the integrate3.0 branch from eaafbdb to 0ef9f78 Compare vineethkuttan force-pushed the integrate3.0 branch from 126a015 to ee60158 Compare tido64 reviewed Oct 29, 2025
| // So we block them at the root, and alias them to the versions in example's node_modules | ||
| resolver: { | ||
| blocklistRE: exclusionList( | ||
| blocklistRE: [ |
There was a problem hiding this comment.
modules.map() returns an array. You don't need these brackets.
| return "force-cache"; | ||
| case ImageSource::CacheStategy::OnlyIfCached: | ||
| return "only-if-cached"; | ||
| //[Windows #15263 |
There was a problem hiding this comment.
This change seems to be intentional from upstream.Please refer to this PR
facebook/react-native#54317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
react-native-community/cli#2491
facebook/metro#1564 (comment)
microsoft/rnx-kit#3783
facebook/react-native@6892dde...5936f29
Type of Change
Erase all that don't apply.
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves [Add Relevant Issue Here]
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.
Changelog
Should this change be included in the release notes: indicate yes or no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow