This repository was archived by the owner on May 20, 2025. It is now read-only.
Move namespace definition to build.gradle #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DmitriyKirakosyan approved these changes Sep 4, 2024
lucen-ms approved these changes Sep 4, 2024
Merged
Minishlink pushed a commit to Minishlink/react-native-code-push that referenced this pull request Sep 26, 2024
* move namespace defenition to build.gradle file * define namespace in build.gradle for module (cherry picked from commit 1f1bd87)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
The namespace declaration in AndroidManifest.xml is currently deprecated. Therefore, following the recommendation, we moved the namespace declaration to build.gradle file.
Related PRs or issues
Issue: #2743