Skip to content

Conversation

@you-n-g
Copy link
Collaborator

@you-n-g you-n-g commented Oct 30, 2022

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation
@you-n-g
Copy link
Collaborator Author

you-n-g commented Oct 30, 2022

Please refer to #1333 for the details.

@you-n-g you-n-g requested a review from lihuoran October 30, 2022 13:26
@you-n-g you-n-g changed the title Remove dropna in exchange Remove Dropna limitation of quote_df in Exchange Oct 30, 2022
Copy link
Contributor

@lihuoran lihuoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@you-n-g
Copy link
Collaborator Author

you-n-g commented Nov 3, 2022

@lihuoran OK. I'll merge it then.
If it is not enough to remove fill_missing_value, feel free to contact me.

@you-n-g you-n-g merged commit ad4a1da into microsoft:huoran/fix_rl_todos Nov 3, 2022
you-n-g added a commit that referenced this pull request Nov 10, 2022
* Refine several todos * CI issues * Remove Dropna limitation of `quote_df` in Exchange (#1334) * Remove Dropna limitation of `quote_df` of Exchange * Impreove docstring * Fix type error when expression is specified (#1335) * Refine fill_missing_data() * Remove several TODO comments * Add back env for interpreters * Change Literal import * Resolve PR comments * Move to SAOEState * Add Trainer.get_policy_state_dict() * Mypy issue Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* Refine several todos * CI issues * Remove Dropna limitation of `quote_df` in Exchange (microsoft#1334) * Remove Dropna limitation of `quote_df` of Exchange * Impreove docstring * Fix type error when expression is specified (microsoft#1335) * Refine fill_missing_data() * Remove several TODO comments * Add back env for interpreters * Change Literal import * Resolve PR comments * Move to SAOEState * Add Trainer.get_policy_state_dict() * Mypy issue Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* Refine several todos * CI issues * Remove Dropna limitation of `quote_df` in Exchange (microsoft#1334) * Remove Dropna limitation of `quote_df` of Exchange * Impreove docstring * Fix type error when expression is specified (microsoft#1335) * Refine fill_missing_data() * Remove several TODO comments * Add back env for interpreters * Change Literal import * Resolve PR comments * Move to SAOEState * Add Trainer.get_policy_state_dict() * Mypy issue Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants