This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Catch stack empty exception #1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 30 commits September 30, 2019 12:03
This reverts commit 6109ac7.
added 5 commits March 18, 2020 18:48
added 2 commits April 17, 2020 13:54
jakebailey reviewed Apr 17, 2020
jakebailey approved these changes Apr 17, 2020
MikhailArkhipov pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Catch stack exception * Undor some formatting * Catch specific exception * Log exception (cherry picked from commit 04e9145)
MikhailArkhipov pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Catch stack exception * Undor some formatting * Catch specific exception * Log exception (cherry picked from commit 04e9145)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1910
Tactical fix since proper handling with running analysis would be much bigger change.