Add JSON path supplier parameter to visitor functions #62
+238 −95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Marcono1234 commented Nov 7, 2021
| | ||
| function assertNodeAtLocation(input: Node | undefined, segments: Segment[], expected: any) { | ||
| let actual = input && findNodeAtLocation(input, segments); | ||
| assert.deepEqual(actual ? getNodeValue(actual) : void 0, expected); |
There was a problem hiding this comment.
Have not replaced this with assert.deepStrictEqual because then the test fails.
| Really cool, thanks @Marcono1234 ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #50
The implementation follows the behavior described in #50:
onObjectBegin,onObjectProperty,onArrayBeginandonLiteralValuea JSON path supplier parameter was addedonObjectPropertythe path refers to the enclosing JSON object; including the current property name in the path already would be a bit inconsistent because it would not really be the path of the current property nameAdditionally I have replaced
assert.equalcalls withassert.strictEqualandassert.deepEqualwithassert.deepStrictEqualbecause these functions are marked as deprecated.I am not that familiar with TypeScript, so any feedback is appreciated!