FIX: Retain original timezone in Python datetime objects #281
+39 −35
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request updates how
datetimeoffsetvalues are handled when reading from SQL Server in the Python bindings. The main change is to preserve the original timezone information in returned Pythondatetimeobjects, instead of always converting them to UTC. Correspondingly, the test suite has been updated to compare datetimes with their original timezone rather than converting to UTC for assertions.Datetimeoffset handling improvements:
datetimeoffsetvalues to UTC inSQLGetData_wrapandFetchBatchData, so Python datetime objects retain their original timezone info. [1] [2]Test suite updates:
tests/test_004_cursor.pyto compare datetimes directly, preserving timezone information, instead of converting to UTC for equality checks. This affects tests for read/write, max/min offsets, DST transitions, executemany, and extreme offsets. [1] [2] [3] [4] [5]