Skip to content

Conversation

@niallnsec
Copy link

Currently builds for Windows ARM64 fail with the following errors:

# github.com/microsoft/go-mssqldb/internal/gopkg.in/natefinch/npipe.v2 /go/pkg/mod/github.com/microsoft/go-mssqldb@v1.8.0/internal/gopkg.in/natefinch/npipe.v2/npipe_windows.go:191:16: undefined: createEvent /go/pkg/mod/github.com/microsoft/go-mssqldb@v1.8.0/internal/gopkg.in/natefinch/npipe.v2/npipe_windows.go:207:8: undefined: getOverlappedResult /go/pkg/mod/github.com/microsoft/go-mssqldb@v1.8.0/internal/gopkg.in/natefinch/npipe.v2/npipe_windows.go:224:12: undefined: waitNamedPipe /go/pkg/mod/github.com/microsoft/go-mssqldb@v1.8.0/internal/gopkg.in/natefinch/npipe.v2/npipe_windows.go:329:8: undefined: connectNamedPipe /go/pkg/mod/github.com/microsoft/go-mssqldb@v1.8.0/internal/gopkg.in/natefinch/npipe.v2/npipe_windows.go:371:10: undefined: disconnectNamedPipe /go/pkg/mod/github.com/microsoft/go-mssqldb@v1.8.0/internal/gopkg.in/natefinch/npipe.v2/npipe_windows.go:384:13: undefined: cancelIoEx /go/pkg/mod/github.com/microsoft/go-mssqldb@v1.8.0/internal/gopkg.in/natefinch/npipe.v2/npipe_windows.go:539:9: undefined: createNamedPipe 

This is due to the vendered npipe.v2 package missing support for ARM64.

This PR fixes the issue by adding the file znpipe_windows_arm64.go which is currently just a straight copy of znpipe_windows_amd64.go

@niallnsec
Copy link
Author

@microsoft-github-policy-service agree company="Turaco Labs"

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.75%. Comparing base (dad23d2) to head (78f849a).

Additional details and impacted files
@@ Coverage Diff @@ ## main #232 +/- ## ========================================== + Coverage 74.71% 74.75% +0.04%  ========================================== Files 32 32 Lines 6410 6410 ========================================== + Hits 4789 4792 +3  + Misses 1333 1331 -2  + Partials 288 287 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants