Add samples to this repo #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| | ||
| You can run [unit tests](tests) as part of `docker run` using the following commands. Running tests in this way is useful to get complete tests results for Docker images. The [sample Dockerfile](Dockerfile) exposes multiple [Dockerfile stages](https://docs.docker.com/engine/reference/commandline/build/#specifying-target-build-stage-target) that you can separately target as part of `docker build` and run. The sample Dockerfile includes a `testrunner` stage with a separate `ENTRYPOINT` for unit testing, which is required to maintain a single Dockerfile. | ||
| | ||
| The following commands rely on [volume mounting](https://docs.docker.com/engine/admin/volumes/volumes/) (that's the `-v` argument in the following commands) to enable the test runner to write test log files to your local drive. Without that, running tests as part of `docker run` isn't as useful. You may need to [Enable shared drives](https://docs.docker.com/docker-for-windows/#shared-drives) first. |
There was a problem hiding this comment.
The comment on shared drives isn't applicable since these are Windows containers. I am removing it.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| | ||
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> |
There was a problem hiding this comment.
Is this intentionally different than the other two projects?
There was a problem hiding this comment.
The other two need to be netcoreapp. This one has the potenial to be netstandard. It aligns with our netstandard-first guidance for libraries.
This was referenced May 1, 2018
This was referenced May 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replacing / improving samples at https://github.com/microsoft/dotnet-framework-docker-samples/
Replacing #122