Fix calls to ResultCode after clang 11 upgrade #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
After upgrading checkedc-clang to release 11, we see that the signature of ResultCode in lit has changed and it now expects 3 parameters. But our checkedc-llvm-test-suite has not been updated and continues to pass only 2 parameters in calls to ResultCode. This causes the following error in the Linux LNT Benchmarking ADO run: "TypeError: __new__() takes exactly 4 arguments (3 given)" Here we are making/fixing calls to ResultCode similar to those in https://github.com/microsoft/checkedc-clang/blob/master/llvm/utils/lit/lit/Test.py#L45 The long term fix is to upgrade the checkedc-llvm-test-suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
After upgrading checkedc-clang to release 11, we see that the signature of
ResultCode in lit has changed and it now expects 3 parameters. But our
checkedc-llvm-test-suite has not been updated and continues to pass only 2
parameters in calls to ResultCode. This causes the following error in the Linux
LNT Benchmarking ADO run:
"TypeError: new() takes exactly 4 arguments (3 given)"
Here we are making/fixing calls to ResultCode similar to those in
https://github.com/microsoft/checkedc-clang/blob/master/llvm/utils/lit/lit/Test.py#L45
The long term fix is to upgrade the checkedc-llvm-test-suite. Issue checkedc/checkedc-clang#992 tracks this.