Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Jun 9, 2021

Fix #3683
Fix #3803

Purpose

What is the context of this pull request? Why is it being done?
The last packages of SDK are 4.13 in NuGet and npm, we have to update the C# and TypeScript components to use the latest changes of the SDK.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Upgrade C# components to use SDK version 4.13.2
  • Upgrade TypeScript components to use SDK version 4.13.5
  • Update Bot-Solutions version to 1.1.0 which will be released for C# and TypeScript
  • Replace deprecated AzureBlobTranscriptStore for BlobsTranscriptStore in C# and TypeScript
  • Remove internal AllowedCallersClaimsValidator to consume the one of the SDK in C# and in JavaScript
  • Remove internal SetSpeakMiddleware to consume the one of the SDK in C# and in JavaScript
  • Remove internal SkillConversationIdFactory to consume the one of the SDK in C# and in JavaScript
  • Replicate changes in Templates for C# and TypeScript
  • Remove botskills vulnerabilities

Tests

Is this covered by existing tests or new ones? If no, why not?
We manually tested the following for TypeScript and C# components

  • Install of dependencies
  • Build of solution
  • Execution of Unit Tests
  • Deployment and publish to Azure
  • Individual communication
  • Connection with Skills
  • Communication with Skills

Communication VA - Skill
image

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Once the Bot-Solutions 1.1.0 for TypeScript and C# packages are published, the samples will work and the generators can be published.
Apart from that, the package-lock.json of the TypeScript samples should be updated too.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation
@lauren-mills lauren-mills merged commit 8fd23eb into microsoft:master Jun 9, 2021
@Batta32 Batta32 deleted the external/feature/southworks/deprecation-plan/update-sdk branch June 9, 2021 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants