This repository was archived by the owner on Jun 30, 2022. It is now read-only.
[C# & TypeScript] Update SDK versions to latest (4.13) #3825
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #3683
Fix #3803
Purpose
What is the context of this pull request? Why is it being done?
The last packages of SDK are 4.13 in NuGet and npm, we have to update the C# and TypeScript components to use the latest changes of the SDK.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
AllowedCallersClaimsValidatorto consume the one of the SDK in C# and in JavaScriptSetSpeakMiddlewareto consume the one of the SDK in C# and in JavaScriptSkillConversationIdFactoryto consume the one of the SDK in C# and in JavaScriptTests
Is this covered by existing tests or new ones? If no, why not?
We manually tested the following for TypeScript and C# components
Communication VA - Skill

Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Once the Bot-Solutions 1.1.0 for TypeScript and C# packages are published, the samples will work and the generators can be published.
Apart from that, the
package-lock.jsonof the TypeScript samples should be updated too.Checklist
General