AppCredentials object model and update to MSAL #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
carlosscastro approved these changes Feb 12, 2020
| # Firstly, looks up a token from cache | ||
| # Since we are looking for token for the current app, NOT for an end user, | ||
| # notice we give account parameter as None. | ||
| auth_token = self.app.acquire_token_silent(self.scopes, account=None) |
There was a problem hiding this comment.
Did you inspect the code for acquire_token_for_client or try whether acquire_token_for_client caches? In the C# flavor of MSAL, acquire_token_for_client does the caching itself without external logic.
There was a problem hiding this comment.
It does appear to cache. The first time through it falls into the fetch. Next pass through it does not. With that said, I did not test for expiration.
…er-python into trboehre/auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #320
This implements the new AppCredentials model.
Ditched ADAL in favor of MSAL (as that team states MSAL is the future).
As a side note, we are using the caching in MSAL instead of our own, which simplifies things.