[#1683] Fix is_skill_claim validation for anonymous authentication #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1683
Description
This PR fixes the order of the validations in the is_skill_claim method to allow using anonymous authentication.
Specific Changes
skill_validationclass to invert the order of the conditions that validate the VERSION_CLAIM and the ANONYMOUS_SKILL_APP_ID to keep consistency with .NET and JS SDKs.test_auth.Testing
This image shows a bot with anonymous authentication working.
And this image shows the test passing in the CI pipeline after the changes.
