Skip to content

[#5276] Update code analysis to latest VS recommendations - Disable rules #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sw-joelmut wants to merge 7 commits into from
Closed

[#5276] Update code analysis to latest VS recommendations - Disable rules #6245

sw-joelmut wants to merge 7 commits into from

Conversation

@sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented Mar 4, 2022 •
edited
Loading

Addresses #5276
#minor

IMPORTANT!

Note: These changes are being address as part of enabling the .NET Analyzers library in the PR #6251.

Description

This PR disables new rules detected by the new .NET Analyzers that are considered high impact.

List:

  • CA1002
  • CA1024
  • CA1711
  • CA2109
  • CA2326
  • CA2327
  • CA2329
  • CA5394
  • CA5404

Testing

This image shows the CI pipeline successfully running after the changes.
imagen
@sw-joelmut sw-joelmut requested a review from a team as a code owner March 4, 2022 17:17
@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Mar 4, 2022
gabog
gabog suggested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add pragma excludes for CA1002, based on the docs we should have probably changed these properties to use IList
Similar issue for CA5404 and CA5394, we should have addressed the issues here rather than suppressing them
@gabog
Copy link
Contributor

gabog commented Mar 22, 2022

We will not address this at the moment.
@gabog gabog closed this Mar 22, 2022
@ceciliaavila ceciliaavila deleted the southworks/fix/disable-analyzers-rules branch July 14, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation: No parity PR does not need to be applied to other languages.

3 participants

@sw-joelmut @gabog