Enhance icon search with tag support and clickable tag filters #748
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the icon search functionality in the WPFGallery application by adding tag support, enabling users to search icons by both name and associated tags, and providing clickable tag filters in the icon detail panel.
Key Changes:
- Added tag metadata to the IconData model and IconsData.json file with comprehensive tags for each icon
- Updated search functionality to match against both icon names and tags using case-insensitive comparison
- Implemented clickable tag chips in the icon detail panel that filter icons when clicked
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IconsData.cs | Added Tags property (List) to the IconData model to store tag metadata |
| IconsData.json | Populated with tag arrays for each icon entry, providing searchable keywords |
| IconsPageViewModel.cs | Enhanced OnSearchTextChanged to search both names and tags; added ApplyTagFilter command for tag chip functionality |
| IconsPage.xaml | Added Tags section with clickable chip buttons styled as IconTagChipButtonStyle; updated search label; bound tag buttons to ApplyTagFilter command |
Note: I was unable to review the actual diff hunks for this pull request as they were not provided in the review context. The analysis above is based on examining the current state of the relevant files in the repository. To provide specific line-by-line feedback and identify potential issues in the changes, I would need to see the actual diff hunks showing which lines were added, removed, or modified.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Fix: #633
Fix: #686
Changes
Microsoft Reviewers: Open in CodeFlow