Update LKG. #6400
Merged
Update LKG. #6400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| The build failed because of a timeout I'll trigger a re-test, but this is likely a problem. @mhegazy |
Contributor
| do they locally pass? |
Member Author
| Yes, they all pass, it just took longer than 20 seconds for |
Contributor
| The last test that @vladima ran Tuesday showed that we have better perf on node v5 than v4. So something does not add up here. Can you get more info? |
Member Author
| I think it might've been an anomaly on Travis. The push build was consistent in timings. https://travis-ci.org/Microsoft/TypeScript/builds/101112874 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.