Skip to content

Conversation

@jakebailey
Copy link
Member

This is microsoft/typescript-go#1604 but here.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 6, 2025
@jakebailey
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 6, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results
@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62726/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 193,884k (± 0.97%) 194,466k (± 1.00%) ~ 192,683k 196,263k p=0.471 n=6
Parse Time 1.30s (± 0.58%) 1.31s (± 0.39%) ~ 1.30s 1.31s p=0.069 n=6
Bind Time 0.72s (± 0.57%) 0.72s (± 0.57%) ~ 0.72s 0.73s p=1.000 n=6
Check Time 9.86s (± 0.23%) 9.89s (± 0.22%) ~ 9.86s 9.92s p=0.075 n=6
Emit Time 2.73s (± 1.21%) 2.74s (± 0.64%) ~ 2.71s 2.76s p=0.468 n=6
Total Time 14.62s (± 0.35%) 14.65s (± 0.22%) ~ 14.60s 14.69s p=0.197 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 956,047 956,047 ~ ~ ~ p=1.000 n=6
Types 415,881 415,881 ~ ~ ~ p=1.000 n=6
Memory used 1,255,018k (± 0.00%) 1,255,056k (± 0.00%) ~ 1,254,996k 1,255,147k p=0.261 n=6
Parse Time 6.55s (± 0.79%) 6.52s (± 0.54%) ~ 6.48s 6.58s p=0.260 n=6
Bind Time 1.87s (± 0.44%) 1.88s (± 0.22%) ~ 1.88s 1.89s p=0.056 n=6
Check Time 32.25s (± 0.22%) 32.31s (± 0.27%) ~ 32.20s 32.44s p=0.258 n=6
Emit Time 14.88s (± 0.19%) 14.89s (± 0.24%) ~ 14.85s 14.95s p=0.809 n=6
Total Time 55.57s (± 0.17%) 55.60s (± 0.20%) ~ 55.49s 55.79s p=0.872 n=6
mui-docs - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 552,568 552,568 ~ ~ ~ p=1.000 n=6
Types 89 89 ~ ~ ~ p=1.000 n=6
Memory used 827,078k (± 0.00%) 827,081k (± 0.00%) ~ 827,063k 827,106k p=0.575 n=6
Parse Time 8.35s (± 0.25%) 8.37s (± 0.14%) ~ 8.36s 8.39s p=0.145 n=6
Bind Time 2.19s (± 0.29%) 2.18s (± 0.24%) ~ 2.18s 2.19s p=0.091 n=6
Check Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Emit Time 0.28s (± 1.47%) 0.28s ~ ~ ~ p=0.405 n=6
Total Time 10.81s (± 0.18%) 10.83s (± 0.12%) ~ 10.81s 10.85s p=0.301 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,277 1,237,277 ~ ~ ~ p=1.000 n=6
Types 259,883 259,883 ~ ~ ~ p=1.000 n=6
Memory used 2,975,188k (±10.00%) 3,095,378k (± 0.03%) ~ 3,093,864k 3,096,466k p=0.093 n=6
Parse Time 6.65s (± 1.76%) 6.69s (± 0.43%) ~ 6.66s 6.74s p=0.630 n=6
Bind Time 2.15s (± 1.87%) 2.16s (± 1.15%) ~ 2.13s 2.20s p=0.688 n=6
Check Time 42.75s (± 0.22%) 42.85s (± 0.34%) ~ 42.61s 43.04s p=0.199 n=6
Emit Time 3.44s (± 4.57%) 3.51s (± 1.83%) ~ 3.44s 3.61s p=0.066 n=6
Total Time 54.98s (± 0.12%) 55.22s (± 0.30%) +0.23s (+ 0.42%) 54.98s 55.40s p=0.020 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,277 1,237,277 ~ ~ ~ p=1.000 n=6
Types 259,883 259,883 ~ ~ ~ p=1.000 n=6
Memory used 3,158,974k (± 0.02%) 3,159,220k (± 0.02%) ~ 3,158,343k 3,160,228k p=0.471 n=6
Parse Time 6.83s (± 0.81%) 6.84s (± 0.30%) ~ 6.81s 6.87s p=0.230 n=6
Bind Time 2.15s (± 1.40%) 2.13s (± 1.40%) ~ 2.08s 2.16s p=0.334 n=6
Check Time 42.88s (± 0.40%) 42.68s (± 0.33%) ~ 42.51s 42.92s p=0.093 n=6
Emit Time 3.57s (± 1.36%) 3.49s (± 2.96%) ~ 3.32s 3.61s p=0.128 n=6
Total Time 55.42s (± 0.25%) 55.16s (± 0.25%) -0.27s (- 0.48%) 54.93s 55.29s p=0.013 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,522 262,522 ~ ~ ~ p=1.000 n=6
Types 104,048 104,048 ~ ~ ~ p=1.000 n=6
Memory used 440,703k (± 0.01%) 440,690k (± 0.01%) ~ 440,590k 440,720k p=0.810 n=6
Parse Time 2.89s (± 0.46%) 2.88s (± 0.42%) ~ 2.87s 2.90s p=0.507 n=6
Bind Time 1.12s (± 0.46%) 1.12s (± 0.36%) ~ 1.11s 1.12s p=0.595 n=6
Check Time 15.95s (± 0.45%) 15.89s (± 0.45%) ~ 15.77s 15.95s p=0.142 n=6
Emit Time 1.31s (± 1.80%) 1.31s (± 1.31%) ~ 1.29s 1.33s p=0.627 n=6
Total Time 21.26s (± 0.35%) 21.20s (± 0.42%) ~ 21.07s 21.29s p=0.470 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,386 225,386 ~ ~ ~ p=1.000 n=6
Types 94,304 94,304 ~ ~ ~ p=1.000 n=6
Memory used 370,054k (± 0.03%) 370,171k (± 0.02%) ~ 370,042k 370,256k p=0.093 n=6
Parse Time 2.82s (± 0.94%) 2.82s (± 1.02%) ~ 2.79s 2.86s p=1.000 n=6
Bind Time 1.61s (± 0.82%) 1.61s (± 1.01%) ~ 1.59s 1.63s p=0.869 n=6
Check Time 16.47s (± 0.35%) 16.56s (± 0.33%) +0.09s (+ 0.52%) 16.48s 16.63s p=0.029 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 20.91s (± 0.35%) 21.00s (± 0.18%) +0.09s (+ 0.42%) 20.96s 21.07s p=0.045 n=6
vscode - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 4,018,694 4,018,694 ~ ~ ~ p=1.000 n=6
Types 1,260,943 1,260,943 ~ ~ ~ p=1.000 n=6
Memory used 3,800,665k (± 0.01%) 3,800,612k (± 0.01%) ~ 3,800,302k 3,800,856k p=0.810 n=6
Parse Time 15.54s (± 0.49%) 15.56s (± 0.65%) ~ 15.42s 15.67s p=0.629 n=6
Bind Time 5.05s (± 0.37%) 5.03s (± 0.63%) ~ 4.99s 5.08s p=0.147 n=6
Check Time 106.14s (± 4.64%) 105.28s (± 3.00%) ~ 101.96s 108.64s p=0.936 n=6
Emit Time 42.27s (±14.51%) 39.96s (± 8.55%) ~ 37.33s 46.79s p=0.936 n=6
Total Time 169.01s (± 5.50%) 165.83s (± 1.72%) ~ 162.32s 169.38s p=0.810 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 379,170 379,170 ~ ~ ~ p=1.000 n=6
Types 166,358 166,358 ~ ~ ~ p=1.000 n=6
Memory used 537,943k (± 0.01%) 537,980k (± 0.01%) ~ 537,940k 538,010k p=0.149 n=6
Parse Time 4.59s (± 0.53%) 4.61s (± 0.87%) ~ 4.56s 4.68s p=0.375 n=6
Bind Time 1.93s (± 0.96%) 1.95s (± 1.24%) ~ 1.93s 2.00s p=0.209 n=6
Check Time 22.55s (± 0.31%) 22.53s (± 0.48%) ~ 22.42s 22.70s p=0.627 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 29.08s (± 0.20%) 29.10s (± 0.49%) ~ 28.96s 29.28s p=0.872 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 690,485 690,485 ~ ~ ~ p=1.000 n=6
Types 208,757 208,757 ~ ~ ~ p=1.000 n=6
Memory used 586,602k (± 0.02%) 587,220k (± 0.04%) +619k (+ 0.11%) 587,025k 587,590k p=0.005 n=6
Parse Time 4.19s (± 0.89%) 4.19s (± 0.66%) ~ 4.16s 4.24s p=0.683 n=6
Bind Time 1.36s (± 1.21%) 1.37s (± 0.61%) ~ 1.35s 1.37s p=0.215 n=6
Check Time 20.61s (± 1.92%) 20.89s (± 1.78%) ~ 20.39s 21.16s p=0.261 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 26.17s (± 1.53%) 26.45s (± 1.37%) ~ 25.93s 26.71s p=0.229 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62726/merge:

Everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

2 participants