LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251030193607558 to main #62695
+183 −102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
typescript-bot added the For Uncommitted Bug There was a problem hiding this comment.
Pull Request Overview
This PR updates TypeScript diagnostic message localizations across multiple languages (Polish, Japanese, French, Spanish, and German). The changes include grammar corrections, new diagnostic messages, and removal of obsolete entries to align with the English source.
Key changes:
- Fixes grammar in the 'const' assertion error message (correcting "assertions" to "assertion" in the English source text reference)
- Adds three new diagnostic messages: side-effect import errors, TypeScript 6 migration information, and checkJs setting descriptions
- Removes two obsolete module resolution-related messages and replaces with updated bundler/node resolution message
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Polish translations with grammar fixes and new diagnostic messages |
| src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Japanese translations with grammar fixes and new diagnostic messages |
| src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates French translations including quotation mark style changes and new messages |
| src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Spanish translations with new diagnostic messages and removes obsolete entries |
| src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates German translations with grammar fixes and new diagnostic messages |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Visit https://aka.ms/ts6 for migration information.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[移行情報については、http://aka.ms/ts6 にアクセスしてください。]]></Val> |
There was a problem hiding this comment.
The URL protocol should be 'https' not 'http'. The English source uses 'https://aka.ms/ts6' but the Japanese translation has 'http://aka.ms/ts6'.
jakebailey approved these changes Oct 30, 2025
jakebailey deleted the lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251030193607558 branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251030193607558 to main with localized lcls