Let isolated declarations fixer add toplevel imports more #60267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The fixer has a tendency to create inline imports, whereas toplevel imports are almost always more readable. And the code already exists, it's just a matter of using it. I assume there may be value in applying this in some other places, but this is the one that's bugging me! Fixes microsoft#60266.
typescript-bot added the For Uncommitted Bug 
| (My company is reviewing the CLA, will take a few days at minimum.) |
| @microsoft-github-policy-service agree company="Notion Labs, Inc." |
jakebailey approved these changes Nov 11, 2024
There was a problem hiding this comment.
This seems right, I think... @andrewbranch Do you have any knowledge here?
andrewbranch approved these changes Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The fixer has a tendency to create inline imports, whereas toplevel imports are almost always more readable. And the code already exists, it's just a matter of using it.
I assume there may be value in applying this in some other places, but this is the one that's bugging me!
Fixes #60266.