Skip to content

Exclude completions of binding pattern variable initializers #52723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandersn merged 3 commits into from
Apr 2, 2025
Merged

Exclude completions of binding pattern variable initializers #52723

sandersn merged 3 commits into from
Apr 2, 2025

Conversation

@zardoy
Copy link
Contributor

@zardoy zardoy commented Feb 11, 2023 •
edited
Loading

Fixes #53049

const {a1} = a/* should not complete a1 */

Real world case:

let pageToReturn const { data: pageData } = await octokit.repos.listTags({ page: page /* pageData is suggested first */ })

Some kind of follow up for #42087

Decided to build on top of #52690 (so there is no conflicts if gets merged)

For now will wait until that PR is merged.
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 11, 2023
@zardoy zardoy mentioned this pull request Mar 1, 2023
Closed
@zardoy zardoy force-pushed the no-self-completions-from-binding-pattern branch from af52d4c to c4d73a0 Compare April 20, 2023 12:50
@zardoy zardoy marked this pull request as ready for review April 20, 2023 12:50
@sandersn
Copy link
Member

sandersn commented Apr 2, 2025 •
edited
Loading

New changes require approval from someone other than sandersn because they were the last pusher.

well this is annoying
@sandersn sandersn merged commit ba663f6 into microsoft:main Apr 2, 2025
32 checks passed
@zardoy
Copy link
Contributor Author

zardoy commented Apr 3, 2025

Thank you! You are the best!
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

4 participants

@zardoy @sandersn @jakebailey @typescript-bot