- Notifications
You must be signed in to change notification settings - Fork 13.2k
Automatically create sort groups based on newlines in organize imports #48330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakebailey merged 9 commits into microsoft:main from MQuy:feature/create-sort-groups-by-newlines Apr 5, 2022
Merged
Automatically create sort groups based on newlines in organize imports #48330
jakebailey merged 9 commits into microsoft:main from MQuy:feature/create-sort-groups-by-newlines Apr 5, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ff8df38 to b89f697 Compare jakebailey requested changes Mar 28, 2022
Member
jakebailey left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks about right to me, but I think what I'd like to see are a few more tests to cover cases where there are comments, e.g., what is the behavior when we have something like:
// polyfill import "lib" // not polyfill import { b } from "lib2"or say
import "lib" // xyz import c from "C"Or similar (this isn't exhaustive). I know the original issue had some code snippets that feature comments.
jakebailey reviewed Mar 28, 2022
jakebailey reviewed Mar 28, 2022
fd96817 to 2c13fec Compare jakebailey reviewed Mar 30, 2022
jakebailey reviewed Apr 5, 2022
aa759f0 to 24e4cd9 Compare f594067 to bd8ce22 Compare jakebailey reviewed Apr 5, 2022
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
jakebailey reviewed Apr 5, 2022
jakebailey approved these changes Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #41494.
Based on @RyanCavanaugh's suggestion #41494 (comment)
when organizing imports in each block of newline-contiguous
turns into