Skip to content

Merge Long Vector Trigonometric Op Exec Tests #7665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Merge Long Vector Trigonometric Op Exec Tests #7665

merged 1 commit into from
Jul 24, 2025

Conversation

alsepkow
Copy link
Contributor

@alsepkow alsepkow commented Jul 22, 2025 •
edited
Loading

Resolves #7629

Merge the long vector trig op exec tests from staging-sm6.9.
Verified locally against WARP:
F:\hlsl.bin\TAEF\x64\te.exe "F:\hlsl.bin\Debug\bin\ExecHLSLTests.dll" /name:LongVector::OpTest::trig* /p:D3D12SDKVersion=1 /p:"ExperimentalShaders=*"
V-FEXrt
V-FEXrt approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@V-FEXrt V-FEXrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing surprising in here but this is my first review of this code area so its probably good to another opinion
bob80905
bob80905 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@alsepkow alsepkow merged commit d64d34c into microsoft:main Jul 24, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Jul 24, 2025
@alsepkow alsepkow deleted the user/alsepkow/MergeTrigonometricTests branch September 6, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@alsepkow @V-FEXrt @bob80905