[NFC] Address compiler warnings: C4146 - A 'grab bag' of remaining instances #7574
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix C4146 warnings: unary minus on unsigned types
Fixes several remaining MSVC C4146 warnings where unary minus was applied to unsigned integers.
This should be the last PR containing MSVC C4146 warning fixes. I will remove the disablement of the warning as an error in a subsequent PR once the other pending PRs are completed.
Changes:
-(unsigned_value)
with~unsigned_value + 1
for offset calculations-1LL
instead of-1ULL
where signed values are intendedFiles changed:
-1ULL
with~0ULL
for bitmasksAll changes are mathematically equivalent and preserve existing behavior while eliminating compiler warnings.
Addresses #7573