Skip to content

Conversation

alsepkow
Copy link
Contributor

Addresses #7550.

Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Collaborator

@bogner bogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally fine other than my comment on the change in SelectionDAGNodes.

Also, the title kind of sounds like this is addressing a very large number of warnings rather than a specific MSVC warning.

@alsepkow alsepkow changed the title [NFC] Address 4146 warnings: Cases where we can swap to using ~ operator [NFC] Address Compiler warnings: C4146 - Cases where we can swap to using ~ operator Jun 18, 2025
@alsepkow alsepkow changed the title [NFC] Address Compiler warnings: C4146 - Cases where we can swap to using ~ operator [NFC] Address compiler warnings: C4146 - Cases where we can swap to using ~ operator Jun 18, 2025
@alsepkow alsepkow merged commit 5aec1ec into microsoft:main Jun 19, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants