[SPIR-V] Explicitly state which layout rules require scalar block layout #7539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
s-perron approved these changes Jun 20, 2025
Keenuts approved these changes Jun 23, 2025
| @shawnhatori, can you try force-push the same commits to your branch again? Seems like one of the MS check is stuck? |
Done - synced the fork. Still looks like that check never ran though. |
| @llvm-beanz do you know why the MS part of the CI seem stuck (and thus prevents merging) |
| /AzurePipelines run |
| Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was trying to debug a Vulkan Storage Buffer-related memory alignment issue in my application where I was using SPIR-V generated via
dxcwith-fvk-use-dx-layout. InSPIR-V.rst, I happened to miss the paragraph that follows the list of layout rules (removed in this proposal). That paragraph starts with "To use scalar layout", which given my use of DirectX layout, I did not think was relevant to me. However, the next sentence of that paragraph sneakily and indirectly mentions thatVK_EXT_scalar_block_layoutis required for the DirectX memory layout as well.I have proposed explicitly stating the extension requirement when the relevant layout rules are listed.