Skip to content

Add DXIL REQUIRES to certain tests that require a minimum validation versoin #7408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025
Merged

Add DXIL REQUIRES to certain tests that require a minimum validation versoin #7408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efa1cd9
add external validation option explicitly
bob80905 Apr 30, 2025
2a63db8
typo
bob80905 Apr 30, 2025
9a7e33c
undo validation test changes
bob80905 May 1, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/clang/test/LitDXILValidation/load-store-validation.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
; REQUIRES: dxil-1-9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should start a convention where we create sub-folders under LitDXILValidation for specific validator version requirements. All new tests would go into the latest folder, and we would have a lit.local.cfg that implements this requirement, so that none of the tests are required to individually state this requirement.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7413
; RUN: not %dxv %s 2>&1 | FileCheck %s

; Ensure proper validation errors are produced for invalid parameters to load and store operations.
Expand Down
1 change: 1 addition & 0 deletions tools/clang/test/LitDXILValidation/vector-validation.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
; REQUIRES: dxil-1-9
; RUN: not %dxv %s 2>&1 | FileCheck %s

; Confirm that 6.9 specific LLVM operations and DXIL intrinsics fail in 6.8
Expand Down