Change default validation behavior #7392
Merged
+18 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
damyanp reviewed Apr 28, 2025
damyanp reviewed Apr 29, 2025
tex3d requested changes Apr 29, 2025
tex3d approved these changes Apr 29, 2025
damyanp approved these changes Apr 29, 2025
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR changes the default validation behavior to use the internal validator by default.
If no options are specified, the internal validator will be used, and if it fails, then compilation fails.
The external validator can still be run but must be explicitly chosen.
Specifying internal works just as before.
There is plenty of testing and infrastructure that needs to be added to verify this change, but that needs to be added in a separate change. This change is step 1.
Addresses #7389