[SPIR-V] Emit error for unsupported HLSL res obj #5956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| ✅ With the latest revision this PR passed the C/C++ code formatter. |
sudonatalie force-pushed the resource-descriptor-heap branch from d445073 to b85a095 Compare 
s-perron reviewed Nov 1, 2023
cassiebeckley approved these changes Nov 2, 2023
Good catch. Updated. @llvm-beanz Can you review the |
s-perron approved these changes Nov 20, 2023
Emit an explicit error message when HLSL ResourceDescriptorHeap is used with -spirv as it is not yet supported. Fixes microsoft#5913
sudonatalie force-pushed the resource-descriptor-heap branch from 3c16fe5 to b406375 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Emit an explicit error message when HLSL
ResourceDescriptorHeaporSamplerDescriptorHeapare used with-spirvas they are not yet supported.Fixes #5913