Add missing '-' for pass in ExtractIRForPassTest.py #5918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The default generated RUN line generated by ExtractIRForPassTest.py adds the desired pass to the options, but forgot to add the '-', so it would fail with difficult to diagnose error in dxopt during argument parsing. This adds the missing '-' so the RUN line doesn't always have to be fixed in this way everytime the script is used.
python3kgae approved these changes Oct 25, 2023
bob80905 approved these changes Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The default generated RUN line generated by ExtractIRForPassTest.py adds the desired pass to the options, but forgot to add the '-', so it would fail with difficult to diagnose error in dxopt during argument parsing.
This adds the missing '-' so the RUN line doesn't have to be fixed in this way every time the script is used.