[Sanitizer] Fix sanitizer fails in msvc #5851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1. Add -sanitizer to hctbuild. 2. Detach pCompileSource in recompile to avoid release freeed memory. 3. Fix Execution test issue about Init size.
tex3d reviewed Oct 11, 2023
pow2clk reviewed Oct 16, 2023
bob80905 reviewed Oct 17, 2023
tex3d reviewed Oct 17, 2023
tex3d approved these changes Oct 17, 2023
bob80905 approved these changes Oct 17, 2023
Merged
python3kgae added a commit that referenced this pull request Oct 18, 2023
Update comment for sanitizer fix in #5851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is for #5876