Disallow multiple shader attributes from existing on a single declaration #5679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
python3kgae approved these changes Sep 11, 2023
pow2clk approved these changes Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a recent spec change on work-graphs that disallows the existence of node + compute attributes on shader declarations. Because of this old behavior, a lot of code worked around the possibility that 2 shader attributes could exist for one declaration. With this old behavior disallowed, we no longer need to account for this possibility. The PR now adds a diagnostic preventing multiple attributes from existing. It will also change all the tests that worked with shaders with multiple shader attributes, and either remove them, or update them so that only one attribute is used.
Fixes #5601