Fix asserts when compiling node objects with -Od #5598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
IsHLSLNodeIOType is supposed to capture all node object types, but was missing output record and output array types. TranslateHLCastHandleToRes had LLVM_FALLTHROUGH in for two cases where it made no sense to fall through to the next case. Updated some tests for -Od compilations. Some CHECKs needed specialization for -Od: - align 4 added to load/store only with optimizations enabled - 2-stage GEPs for accessing matrix elements - no CSE of index/annotate node handle
Without optimizations, GEP chains may be used to access multi-dim arrays within structures. These arrays are legal within the DXIL structure, but not allowed as an intermediate pointer returned from a GEP. This change runs MergeGepUse after lowering UDT types to merge and eliminate GEPs that return multi-dim array pointers. A side-effect of running MergeGepUse is that GEPs are marked as inbounds.
dmpots approved these changes Aug 25, 2023
adam-yang approved these changes Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
IsHLSLNodeIOType is supposed to capture all node object types, but was missing output record and output array types.
TranslateHLCastHandleToRes had LLVM_FALLTHROUGH in for two cases where it made no sense to fall through to the next case.
MergeGepUse is needed after lowering GetRecordPtr to collapse GEP chains that could result in intermediate multi-dimension array pointers from GEPs, which is considered an invalid DXIL type.
Updated some tests for -Od compilations. Added a test for the multi-dim GEP case.
Some CHECKs needed specialization for -Od:
Fixes #5597