[Verifier] Add verifier tests to catch MaxRecord errors earlier #5484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bob80905 changed the title 
llvm-beanz reviewed Aug 2, 2023
…tions for each shader kind
llvm-beanz approved these changes Aug 3, 2023
python3kgae reviewed Aug 3, 2023
| } | ||
| | ||
| TEST_F(VerifierTest, RunMaxRecordsAttribute) { | ||
| CheckVerifiesHLSL(L"max_output_records_duplicate.hlsl"); |
There was a problem hiding this comment.
Is it possible to make these tests lit FileCheck test?
There was a problem hiding this comment.
No, this is targeting the release branch.
There was a problem hiding this comment.
Why release branch cannot have lit FileCheck test?
There was a problem hiding this comment.
Because we won't hide taef for release branch?
There was a problem hiding this comment.
The preview branch is over a month old and doesn't have all the changes in main to move to LIT.
There was a problem hiding this comment.
Do we plan to merge the LIT change to preview branch?
python3kgae approved these changes Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is one of several more PR's that move diagnostic emission earlier for specific errors, so that the verifier can catch these errors. This PR focuses on the MaxRecord* attributes applied on parameters. Specifically, there are 2 behaviors that this PR will allow DXC to detect earlier:
Some tests have been merged or deleted to consolidate these verifier tests. There is still some behavior that cannot be tested at this time (verifying that MaxRecordsSharedWith doesn't reference an invalid parameter name), which will be addressed in the future. It's likely that this location is too early to properly validate this behavior, and the tests for this behavior may need to be left at the same location.
This PR is one of a few that will help implement this task:
#5368