[NFC] Add more information on testing MDVals insertion in EmitDxilFunctionProps #5335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ze of 30, instead of current push_back
python3kgae reviewed Jun 28, 2023
tools/clang/test/HLSLFileCheck/hlsl/workgraph/test_EmitDxilFunctionProps_MDVals.hlsl Outdated Show resolved Hide resolved
| ❌ Build DirectXShaderCompiler 1.0.3437 failed (commit f84b117f21 by @bob80905) |
python3kgae approved these changes Jun 28, 2023
tex3d reviewed Jun 30, 2023
tools/clang/test/HLSLFileCheck/hlsl/workgraph/test_EmitDxilFunctionProps_MDVals.hlsl Outdated Show resolved Hide resolved
tex3d reviewed Jun 30, 2023
tools/clang/test/HLSLFileCheck/hlsl/workgraph/test_EmitDxilFunctionProps_MDVals.hlsl Outdated Show resolved Hide resolved
… for extra coverage.
bob80905 changed the title bob80905 changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A recent change from a recent PR includes changes to how the MDVals data structure inside of EmitDxilFunctionProps gets elements (push_back instead of index assignment).
However, there was no accompanying test for these changes, because HLSLFileCheck\hlsl\workgraph\called_function_arg_nodeoutput.hlsl exercised this code path and failed without the MDVals changes.
This PR adds some extra context to the above test so that the extra purpose the above test serves isn't lost with time.
The test passes with the MDVals pushback changes, and fails with the original valIdx index assignments.