Skip to content

Review issues with redundant OutputComplete elimination change #5363

@llvm-beanz

Description

@llvm-beanz

Redundant OutputComplete elilmination doesn't look like it's quite in the right place.

Moving the DxilMod init code was unnecessary, hlsl::OP can be retrieved from the m_pHLModule instead, as the others do.

See

hlsl::DxilModule& DxilMod = M.GetOrCreateDxilModule(SkipInit);

I don't think this code should have been moved up here, above the comment that related to this step: // High-level metadata should now be turned into low-level metadata.
I think the code that gets rid of OutputComplete calls with zeroinit handle should probably be moved to some other (DCE-like) pass, later (since further optimization may produce this as well).

Metadata

Metadata

Assignees

Labels

sm6.8Shader Model 6.8

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions