Skip to content

Conversation

@benbrown
Copy link
Contributor

@benbrown benbrown commented Oct 3, 2025

Fixes #5514

Description

This fixes the streaming behavior where new interim messages will replace the old, appear to append the message as it streams in. This is a follow-up to #5517 which initially introduced support for parsing and processing those entities.

However, this small additional change was required for the rendering process to properly find the existing message and update it rather than insert a new message.

Specific Changes

This fix was achieved by capturing the typingActivityId along with the main activityId in the nextActivityToId map such that it can be found the second time around.

In addition, added html2/livestream/entities.*, a selection of tests that demonstrate that the behavior with entities matches the behavior with channelData.

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)
OEvgeny
OEvgeny previously approved these changes Oct 14, 2025
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented, also few things need to be answered by Eugene.

@OEvgeny OEvgeny enabled auto-merge (squash) October 31, 2025 20:08
@OEvgeny OEvgeny merged commit a8a3376 into microsoft:main Oct 31, 2025
97 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants