- Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix streaming behavior by capturing typingActivityId in nextActivityIdToKeyMap #5609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OEvgeny merged 20 commits into microsoft:main from benbrown:users/benbro/fix-streaming-behavior Oct 31, 2025
Merged
Fix streaming behavior by capturing typingActivityId in nextActivityIdToKeyMap #5609
OEvgeny merged 20 commits into microsoft:main from benbrown:users/benbro/fix-streaming-behavior Oct 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…her than channelData
This results in a single combined message rather than 3 separate messages
….com/benbrown/BotFramework-WebChat into users/benbro/fix-streaming-behavior
OEvgeny previously approved these changes Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
compulim reviewed Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented, also few things need to be answered by Eugene.
…com/benbrown/BotFramework-WebChat into users/benbro/fix-streaming-behavior
OEvgeny approved these changes Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This fixes the streaming behavior where new interim messages will replace the old, appear to append the message as it streams in. This is a follow-up to #5517 which initially introduced support for parsing and processing those entities.
However, this small additional change was required for the rendering process to properly find the existing message and update it rather than insert a new message.
Specific Changes
This fix was achieved by capturing the typingActivityId along with the main activityId in the nextActivityToId map such that it can be found the second time around.
In addition, added html2/livestream/entities.*, a selection of tests that demonstrate that the behavior with entities matches the behavior with channelData.
-
CHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed