This repository was archived by the owner on Oct 3, 2025. It is now read-only.
[Skills Everywhere][#422][DotNet][JS] Replace custom SkillConversationIdFactory instance by SDK SkillConversationFactory #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ceciliaavila requested review from EricDahlvang, carlosscastro, gabog and mrivera-ms as code owners 
gabog approved these changes May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #422
Description
This PR updates the use of the SkillConversationIdFactory class for DotNet and JavaScript bots removing the existing custom class in favor of the one in BotBuilder SDK.
Specific Changes
SkillConversationIdFactoryinstances to use the BotBuilder SDK class forDotNetandJavaScript.conversationIdFactoryparameter reference inTokenExchangeSkillHandlerforJavaScript.SkillConversationIdFactorycustom class and file fromDotNetandJavaScript.Testing
The following image show the pipeline continues to work after the changes.
