No need to manually remove headers in fetch function (fixes issue#55) #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… theres no need to manually remove them
jonnybarnes changed the title barnabywalters added a commit that referenced this pull request Aug 16, 2014
No need to manually remove headers in fetch function (fixes issue#55)
Collaborator
| Thanks so much for debugging and fixing this! Merging into master now, and it’ll be included in the next tagged release. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Having
CURLOPT_HEADERset tofalsealready removes the HTTP headers from the response, so we don't need to manually remove headers, we can just pass the response straight to the parse function.