unicodeTrim: Fix PHP 8.2 deprecation #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mbstring extension in PHP 8.2 deprecates `HTML-ENTITIES` encoding: https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated However, there is no need to use it to the UTF-8 representation of NBSP, one can just directly use `\u{0a}` (or `\xc2\x0a` for PHP < 7.0). Or, even better, we can enable `PCRE_UTF8` mode: https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php That will remove all Unicode whitespace characters, not just the ASCII ones and nbsp because `u` modifier in PHP enables `PCRE_UCP` as well `PCRE_UTF` options: php/doc-en#2831 It is supposed to be available since PHP 5.1: https://www.phpbb.com/community/viewtopic.php?t=733515
jtojnar force-pushed the wip/jtojnar/unitrim-mbstring-depr branch from aa85520 to 7e990a6 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
mbstring extension in PHP 8.2 deprecates
HTML-ENTITIESencoding:https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated
However, there is no need to use it to the UTF-8 representation of NBSP, one can just directly use
\u{0a}(or\xc2\x0afor PHP < 7.0).Or, even better, we can enable
PCRE_UTF8mode:https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php
That will remove all Unicode whitespace characters, not just the ASCII ones and nbsp because
umodifier in PHP enablesPCRE_UCPas wellPCRE_UTFoptions:php/doc-en#2831
It is supposed to be available since PHP 5.1:
https://www.phpbb.com/community/viewtopic.php?t=733515