Skip to content

Fix for incorrect timestamp parsing when authored timestamp has a Z offset #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2018
Merged

Fix for incorrect timestamp parsing when authored timestamp has a Z offset #154

merged 2 commits into from
Mar 15, 2018

Conversation

aaronpk
Copy link
Member

@aaronpk aaronpk commented Mar 15, 2018

closes #153
aaronpk added 2 commits March 15, 2018 08:54
@aaronpk
add failing test for timestamp with Z offset
bbd6569 
for #153
@aaronpk
fix for #153
9cdf579 
adds check for Z when checking whether to use the implied timezone closes #153
@aaronpk aaronpk requested a review from gRegorLove March 15, 2018 16:25
@sknebel
Copy link
Member

sknebel commented Mar 15, 2018

LGTM
@aaronpk
Copy link
Member Author

aaronpk commented Mar 15, 2018

Thanks, merging and doing a release asap to get this fix out.
@aaronpk aaronpk merged commit 5a98ead into microformats:master Mar 15, 2018
@Zegnat
Copy link
Member

Zegnat commented Mar 15, 2018

LGTM too.

So people know what is being changed: the regular expression is checking whether a date string has a time zone, and otherwise appending an implied time zone. The check did not look for Z (GMT/UTC) as a time zone previously and appended the implied time zone behind an already in place Z. This simply adds the Z to the check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@aaronpk @sknebel @Zegnat