Allow changing subscription name #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
seanchambo force-pushed the feature/change-subscription-name branch 2 times, most recently from 04ae39f to 8d5b239 Compare 
Contributor Author
| @michalkvasnicak Any chance you could give this a review? |
seanchambo force-pushed the feature/change-subscription-name branch from fc70e0a to 57e9d5a Compare 
michalkvasnicak approved these changes Nov 13, 2020
Owner
| @seanchambo thank you very much. Released in 1.0.0-alpha.19.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We are using this in a multi-tenanted application and we want to be able to prefix subscriptions names with the tenant name. This will then allow us to only publish events to certain subscriptions based on the tenancy.
Let me know your thoughts on this.