[major] Dropping the boto3_refresh_session.ecs module #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently, automatic credential refresh is handled already by ECS / boto. The intended purpose of the ECS module was for local testing or to accommodate bespoke endpoints by modulating the constants in `ecs.py`. However, it is far easier for users to instead use `custom.py`. This makes sense. Users with complicated authentication flows are more likely to find value from the custom module. This also reduces the overall complexity of boto3-refresh-session, which is attractive for users. Hence, I have decided to drop the ECS module, as it appears superfluous when the custom module does what users want far better and simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, automatic credential refresh is handled already by ECS / boto for users employing the standard ECS credential service. The intended purpose of the ECS module was for local testing or to accommodate non-standard credential services and endpoints by modulating the constants in
ecs.py. However, it is far easier for users to instead usecustom.py. This makes sense. Users with complicated authentication flows, such as an internal credential service in a large company, are more likely to find value from the custom module than the ecs module. This also reduces the overall complexity of boto3-refresh-session, which is attractive for users. Hence, I have decided to drop the ECS module entirely, as it appears superfluous when the custom module does what users want far better and simpler.