translation in getDisplayName #606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Correct! but with your changes we're going to have a double look up in the T9n keys: see this line Could you please try removing this second one and verify everythings work fine? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
All the language using lowercase id as the t9n key not displayname.
Current problem is the id like email, username will be capitalize to Email, Username, so will be translate failed.
https://github.com/softwarerero/meteor-accounts-t9n/blob/master/t9n/en.coffee
https://github.com/softwarerero/meteor-accounts-t9n/blob/master/t9n/zh_cn.coffee