Architecture coverage test #803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…a-chorna/metatrain into architecture-coverage-test
…a-chorna/metatrain into architecture-coverage-test
Collaborator Author
pfebrer reviewed Oct 8, 2025
| with: | ||
| python-version: "3.13" | ||
| - run: pip install tox | ||
| - run: pip install tox coverage[toml] |
Contributor
There was a problem hiding this comment.
Is it possible to do this in tox.ini instead of here in the workflow file?
Contributor
There was a problem hiding this comment.
Then it would generate the coverage also when running locally
Collaborator Author
There was a problem hiding this comment.
Hmm worth trying then, thanks for suggestion
Member
The llpr/gap/nanopet parts of the code should also have tests, it is weird there is 0 coverage reported for these. |
Luthaf reviewed Oct 9, 2025
Luthaf reviewed Oct 9, 2025
…osmo/metatrain into architecture-coverage-test
Collaborator Author
| The job is failing as the architecture tests for LLPR are not executed, see #900 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please go the the
Previewtab and select the appropriate PR template:📚 Documentation preview 📚: https://metatrain--803.org.readthedocs.build/en/803/