mo/bootstrap

[monken]

Mirrors

• the links on the mirrors page are red (monospace), but the link underline is still a shade of blue.

Sidebar

• The top-left button does nothing on home
• Has "toggle table of contents" on release page (where there is no TOC)

Wrapper

• Change "Fork me" back to "Fork metacpan.org" to avoid the confusing "me" with the dist being looked at
• no "Fork" link in phone view
• Which link text is better, "Bugs" or "Feedback"
• Bytemark logo touches the bottom (looks like it could be cut off).
• Bytemark logo seems really tiny.

Author

• the "Favorites" heading disappears ("Date" always shows)
• Some releases have long enough abstract to get two lines... For others the Uploaded date gets lost of the right side (ellipsis)

Sidebar

• Search box is on top of "EMAIL" text
• No pause id
• No gravatar?
• Browse CPAN dir disappears when sidebar can be scrolled (has blog link) (ex: RWSTAUNER)
• Location gets truncated (ex: GETTY)
• Profiles don't wrap (ex: OALDERS)

Release

• A little more room/distinction b/t the release info and the footer (a border line, maybe?)
• Sidebar: "Latest" link falls off the bottom

Module

• Clicking an internal pod link (like L</new>) the heading is hidden behind the top bar.
• Links to other modules are absolute (not helpful running locally) (#260)

++Leaderboard

• Graphics are too wide
• Flows over the Recent link
• Sidebar button does nothing, If we put the recent link in the sidebar that kills two birds with one stone :-)

General

• Takes a long time to load and makes a lot of requests (many i see are for .less files)

Issues unrelated to bootstrap

• Toggle pod shows up on Changes file
• Can't get Sign-in to work

[ranguard]

Does anyone have time/understanding about rebasing this?

• Otherwise I'll start a bootstrap3 branch off of master and try implement that instead (this will be useful as reference)

[oalders]

I'll try to rebase this sometime this week.

[oalders]

Will push the rebased results to a new branch.

[oalders]

I started a rebase, but I'd say it's non-trivial. After about 45 minutes, I'm only 9 commits in. Maybe we could squash this branch into one commit and then try to apply that to a branch that's a copy of master. Trying to do a rebase on all of these commits just seems like madness.

[ranguard]

Sounds good - do it :)

On 5 Jan 2014, at 06:15, Olaf Alders notifications@github.com wrote:

I started a rebase, but I'd say it's non-trivial. After about 45 minutes,
I'm only 9 commits in. Maybe we could squash this branch into one commit
and then try to apply that to a branch that's a copy of master. Trying to
do a rebase on all of these commits just seems like madness.

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/862#issuecomment-31597583
.

[monken]

Rebased on master. I hope I didn't miss too much. Please double check if something obvious is missing.

We should probably set up a subdomain so we can make people test the bootstrap version, especially on mobile devices. Tests need to be fixed as well I assume.

[oalders]

[08:19:12] [22:54:00] ranguard: the bootstrap branch has a bunch of broken tests
[08:19:12] [22:54:37] https://travis-ci.org/CPAN-API/metacpan-web/jobs/17365732
[08:19:12] [22:57:09] the template for root/pod.html is really different in the bootstrap branch. about 40 lines shorter
[08:19:12] [22:58:07] mo_: what's your schedule like for getting this up to speed? i feel like you're probably the best person to do it
[08:19:12] [22:59:03] the bootstrap branch has been failing at least since the merge https://travis-ci.org/CPAN-API/metacpan-web/builds/16411246
[08:19:12] [22:59:34] i think the failures have stayed constant with the new changes to it

...

[08:32:52] my inclination at this point regarding the bootstrap branch is to try a new branch off master, include bootstrap 3 and see if it breaks anything
[08:33:23] if it doesn't break functionality or look crazy, we could merge that and then slowly port over templates
[08:33:46] that seems easier than picking through a lot of template changes and fixing the tests
[08:34:36] we could pick changes from mo's branch as we go, if we like
[08:34:47] but right now to me it seems overwhelming to work with
[08:34:56] mo_: ^^ unless you have time to sort out mo/bootstrap tests I agree with oalders