Skip to content

Conversation

@haarg
Copy link
Member

@haarg haarg commented Jun 1, 2025

No description provided.

@haarg haarg force-pushed the haarg/no-force-sort-changelog branch from b45ecca to 53f2b34 Compare June 1, 2025 14:09
@codecov
Copy link

codecov bot commented Jun 1, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.53%. Comparing base (b64e10a) to head (d1e227b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
lib/MetaCPAN/Web/Model/API/Changes.pm 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #3367 +/- ## ========================================== + Coverage 73.34% 73.53% +0.18%  ========================================== Files 67 67 Lines 2345 2354 +9 Branches 331 333 +2 ========================================== + Hits 1720 1731 +11  Misses 500 500 + Partials 125 123 -2 
Files with missing lines Coverage Δ
lib/MetaCPAN/Web/Model/API/Changes.pm 94.52% <95.45%> (+5.45%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@haarg haarg force-pushed the haarg/no-force-sort-changelog branch from 53f2b34 to 3217c31 Compare June 28, 2025 07:49
Some changelogs have unusual orders, or have made mistakes with versioning. But most change logs will have the most recent releases at the beginning or the end of the file. If the first or last release found matches the version we are looking for, just use the order of the file as is. Only sort the entries if it isn't found at the start or end.
@haarg haarg force-pushed the haarg/no-force-sort-changelog branch from 3217c31 to d1e227b Compare June 28, 2025 11:51
@haarg haarg requested a review from oalders June 28, 2025 21:17
Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test! 🙏🏻

@haarg haarg added this pull request to the merge queue Jun 28, 2025
Merged via the queue into master with commit e8d2f39 Jun 28, 2025
10 checks passed
@haarg haarg deleted the haarg/no-force-sort-changelog branch June 28, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants