Return 404 for invalid path: /release//File-Stat-Convert #3156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #3156 +/- ## ========================================== + Coverage 72.85% 73.00% +0.14% ========================================== Files 69 69 Lines 2391 2393 +2 Branches 338 339 +1 ========================================== + Hits 1742 1747 +5 + Misses 521 520 -1 + Partials 128 126 -2
|
ranguard force-pushed the leo/gh3155_return_404 branch 2 times, most recently from 759dae9 to 1ff24a0 Compare 
ranguard force-pushed the leo/gh3155_return_404 branch from 1ff24a0 to eafbb34 Compare 
Member Author
| #3157 is better |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Return 404 for invalid paths, e.g. /release//File-Stat-Convert instead of a 500 - fix #3155
Please could you run perl tidy on this - I don't have the Perl setup