Show user avatar in account button #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rewrite the user data fetching using modern APIs to avoid the X-Requested-With header, and add a preload tag to load the login status data as early as possible. This should decrease the time before we're able to display the user's account icon. Also remove the extraneous function when loading user data. It includes a comment referencing possibly optimizing for when there is no login cookie. But the login cookie is http only, so we can't check it in javascript. The response from login_status without a cookie is cached, so there isn't any real opportunity for further optimization or caching. So the comment can also be removed as extraneous.
oalders approved these changes Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This shows the gravatar for logged in users that have a PAUSE account linked.
In the future, we could consider extending this to show GitHub avatars for users that don't have a PAUSE account.