Convert template engine to Text::Xslate #2454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oalders previously approved these changes Apr 15, 2021
| I think this will have to go out of draft mode in order for CI to run. |
haarg force-pushed the text-xslate branch 2 times, most recently from cc1ef31 to 2f3328c Compare 
| All of the templates are now converted. Still needs substantial testing and review. |
| Has some tidy and rendering errors. |
Text::Xslate is meant to be faster than other templating engines, and provides some other capabilities to make templates more reusable, such as template inheritance. Previously we were using Template::Alloy, but it has some inconsistent behaviors, such as either not outputting overloaded objects, or not applying automatic escaping to them, depending on which version is used.
| Tests are passing. |
| I'm going to temporarily move this out of draft mode to see if we can get the Docker build to run. |
| It doesn't show up as an available branch for the workflow. It may need to be rebased. Probably a good idea since there's the one merge conflict. |
| Oh, it's because you've forked. |
| Replaced by #2490 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
WIP of converting the templates to use Text::Xslate